Fix expired test certificates #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So some test certificates had expired over the summer period which meant that tests would suddenly fail when trying to build the project..
For some reason, these certificates along with some derived info were hardcoded in the test code while also being present in the resources directory.
This fix renews the certificates and ensures that they are always loaded from the resource-files instead of the hardcoded solution. It also provides a script for easy renewal of the certs for future use.
While my initial idea was to make it part of the test code to keep the certificates up-to-date, I figured that wouldn't be an optimal solution either as test resources should really just be static files, so I made the compromise of having to just update the certs manually. At least it only has to be done once every 10 years..