feat: ACI-2805 Add flag to follow xcode symlinks #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ddPath, | ||
| xcodeCachePath, | ||
| followSymlinks, | ||
| logger, |
Collaborator
Author
There was a problem hiding this comment.
imrekel
reviewed
Sep 10, 2024
internal/xcode/file_group_info.go
Outdated
|
|
||
| return nil | ||
| if fileInfo.Mode()&os.ModeSymlink != 0 { | ||
| return collectSymlink(path, fgi, followSymlinks, rootDir, logger) |
Contributor
There was a problem hiding this comment.
I don't get it, if a file is symlink, we call collectSymlink on it. But collectSymlink will call collectFileMetadata on the file if it's not a directory. Do I miss something on how the circular method calls are broken?
Collaborator
Author
There was a problem hiding this comment.
collectSymlink() will call resolveSymlink() to resolve the symlink and collect the file info on that target. The resolution is called recursively until we find a regular file, so collectFileMetadata() is called again with the target files only
imrekel
reviewed
Sep 11, 2024
imrekel
reviewed
Sep 11, 2024
imrekel
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.