Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion codesign/certificates.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,10 @@ const (

var (
iOSCertificateNames = []string{
"iPhone Developer", //type: "iOS Development"
"iPhone Developer", // type: "iOS Development"
"iPhone Distribution", // type: "iOS Distribution"
"Apple Development", // type: "iOS Development for Xcode 11", id: "83Q87W3TGH"
"Apple Distribution", // type: "iOS Distribution for Xcode 11", id: "WXV89964HE"
}

macOSCertificateNames = []string{
Expand All @@ -32,6 +34,8 @@ var (
macOSInstallerCertificateNames = []string{
"3rd Party Mac Developer Installer", // type: "Mac Installer Distribution"
"Developer ID Installer", // type: "Developer ID Installer"
"Apple Development", // type: "iOS Development for Xcode 11", id: "83Q87W3TGH"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems Apple Development and Apple Distribution should be moved to the macOSCertificateNames, they are macOS codesigning certificates.

you can validate it, just create a new macOS project using Xcode 11, with default options. The project's Code Signing Identity will be set to: Apple Development. Now if you execute codeswigndoc against this project, it will fail: failed to analyze archive, error: installed certificate not found with common name or sha1 hash: Apple Development: XYZ

"Apple Distribution", // type: "iOS Distribution for Xcode 11", id: "WXV89964HE"
}
)

Expand Down