Apple Development & Apple Distribution certificates #112
Conversation
Adds support for new types of Apple certificates introduced in Xcode 11
|
@rozd Is there a way to install your fork with the fix without checking out the repo and installing all the required tools? Could you for example upload a build for macOS maybe? :) |
| macOSInstallerCertificateNames = []string{ | ||
| "3rd Party Mac Developer Installer", // type: "Mac Installer Distribution" | ||
| "Developer ID Installer", // type: "Developer ID Installer" | ||
| "Apple Development", // type: "iOS Development for Xcode 11", id: "83Q87W3TGH" |
There was a problem hiding this comment.
it seems Apple Development and Apple Distribution should be moved to the macOSCertificateNames, they are macOS codesigning certificates.
you can validate it, just create a new macOS project using Xcode 11, with default options. The project's Code Signing Identity will be set to: Apple Development. Now if you execute codeswigndoc against this project, it will fail: failed to analyze archive, error: installed certificate not found with common name or sha1 hash: Apple Development: XYZ
|
@godrei There are many people waiting for this PR. You could easily have fixed and merged it by now. It is literally a two line change. Please stop dragging your feet... |
|
Hi, @wayne530 I just wanted to let the original author finish the PR. My original plan was to do what you recommended, after giving some time for the author to fix it. Other than that we do not merge PRs with open change requests, to keep the master branch as stable as possible. |
|
Sorry guys I missed the comments on this thread :/ Thank you @godrei to gave me a chance to fix an issue in this PR 😃 |
4 participants
Initial support for new types of Apple certificates introduced in Xcode 11