Fix new Apple certificates listing #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpusok
reviewed
Oct 4, 2019
codesign/certificates.go
Outdated
| "Mac Developer", // type: "Mac Development" | ||
| "3rd Party Mac Developer Application", // type: "Mac App Distribution" | ||
| "Developer ID Application", // type: "Developer ID Application" | ||
| "Apple Development", // type: "iOS Development for Xcode 11", id: "83Q87W3TGH" |
Contributor
Author
There was a problem hiding this comment.
This is the id of the cert type on the dev portal, but as we do not use them, i will remove that part of the comment.
Other than that previous cert type's comments, showed how the cert appears in Xcode.
lpusok
approved these changes
Oct 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the issue mentioned here: #112 (comment)