Mac os fix #83
Merged
Mac os fix #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cOS_Fix # Conflicts: # codesigndoc/codesigngroup.go
godrei
reviewed
Jun 12, 2018
| profilesMap := map[string]profileutil.ProvisioningProfileInfoModel{} | ||
| for _, group := range codeSignGroups { | ||
| certificate := group.Certificate | ||
| certificate := group.Certificate() |
Contributor
There was a problem hiding this comment.
do not forget about the mac installer certificates
godrei
reviewed
Jun 12, 2018
codesigndoc/codesigndoc.go
Outdated
| profilesToExport := []profileutil.ProvisioningProfileInfoModel{} | ||
|
|
||
| if certificatesOnly { | ||
| ipaExportCertificate, err := collectIpaExportCertificate(certificate, installedCertificates) |
Contributor
There was a problem hiding this comment.
collectIpaExportCertificate -> collectExportCertificate or similar (since it is may a macos export)
godrei
reviewed
Jun 12, 2018
codesigndoc/codesigndoc.go
Outdated
| profilesToExport := []profileutil.ProvisioningProfileInfoModel{} | ||
|
|
||
| if certificatesOnly { | ||
| ipaExportCertificate, err := collectIpaExportCertificate(certificate, installedCertificates) |
Contributor
There was a problem hiding this comment.
Also make sure that collectIpaExportCertificate has the export methods updated regarding to the macos export
godrei
reviewed
Jun 28, 2018
codesigndoc/codesigngroup.go
Outdated
| exportMethods := []string{"development", "app-store"} | ||
|
|
||
| if isMacArchive { | ||
| exportMethods = append(exportMethods, "developer-id", "installer") |
godrei
reviewed
Jun 28, 2018
codesigndoc/codesigngroup.go
Outdated
| // collectIpaExportCodeSignGroups returns the codesigngroups required to export an ipa with the selected export methods | ||
| func collectIpaExportCodeSignGroups(archive xcarchive.IosArchive, installedCertificates []certificateutil.CertificateInfoModel, installedProfiles []profileutil.ProvisioningProfileInfoModel) ([]export.IosCodeSignGroup, error) { | ||
| iosCodeSignGroups := []export.IosCodeSignGroup{} | ||
| func collectIpaExportCodeSignGroups(archive Archive, installedCertificates []certificateutil.CertificateInfoModel, installedProfiles []profileutil.ProvisioningProfileInfoModel) ([]export.CodeSignGroup, error) { |
Contributor
There was a problem hiding this comment.
pls serahc for ipa and remove everywhere we do not need it.
godrei
reviewed
Jun 28, 2018
cmd/scan.go
Outdated
| First of all ` + colorstring.Red("please make sure that you can Archive your app from "+e.tool+".") + ` | ||
| codesigndoc only works if you can archive your app from ` + string(e.tool) + `. | ||
| If you can, and you get a valid IPA file if you export from ` + string(e.tool) + `, | ||
| If you can, and you get a valid IPA/.app file if you export from ` + string(e.tool) + `, |
Contributor
There was a problem hiding this comment.
either .ipa or IPA + .app or APP
godrei
reviewed
Jun 28, 2018
codesigndoc/codesigngroup.go
Outdated
| selectedTeam := "" | ||
| var certsForSelectedExport []certificateutil.CertificateInfoModel | ||
| log.Debugf("InstalledCerts: %v\n", installedCertificates) | ||
| selectedCertificates, err = filterSertificates(selectedExportMethod, "", selectedCertificates, archiveCertificate, installedCertificates, installedInstallerCertificates) |
This was referenced Jul 3, 2018
Closed
godrei
approved these changes
Jul 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.