Skip to content

Conversation

@naveen-bitrise
Copy link
Contributor

@naveen-bitrise naveen-bitrise commented Dec 27, 2024

Added testFlightInternalTestingOnly to GenerateApplicationExportOptions method.

GenerateApplicationExportOptions calls addTestFlightInternalTestingOnly method.

Added testFlightInternalTestingOnly appStore option in the v1 branch. I have created another PR for it which has to be merged first, and the go.mod file needs to be updated before this PR can be approved and merged.

@godrei
Copy link
Contributor

godrei commented Jan 7, 2025

Please fix the existing tests and add at least one new test case (for the TestExportOptionsGenerator_GenerateApplicationExportOptions_ForAutomaticSigningStyle), which verifies that the new option appears in the generated export options.

@naveen-bitrise
Copy link
Contributor Author

@godrei I added the tests, however there are some merge conflicts. I am not sure how to resolve them as they have to do with dependencies. could you help?

@godrei godrei merged commit 5dded42 into bitrise-io:master Jan 14, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants