Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions exportoptionsgenerator/exportoptionsgenerator.go
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ func (g ExportOptionsGenerator) GenerateApplicationExportOptions(
archivedWithXcodeManagedProfiles bool,
codeSigningStyle exportoptions.SigningStyle,
xcodeMajorVersion int64,
testFlightInternalTestingOnly bool,
) (exportoptions.ExportOptions, error) {
mainTargetBundleID, entitlementsByBundleID, err := g.applicationTargetsAndEntitlements(exportMethod)
if err != nil {
Expand Down Expand Up @@ -91,6 +92,12 @@ func (g ExportOptionsGenerator) GenerateApplicationExportOptions(
exportOpts = addManualSigningFields(exportOpts, codeSignGroup, archivedWithXcodeManagedProfiles, g.logger)
}

if xcodeMajorVersion >= 15 {
if testFlightInternalTestingOnly {
exportOpts = addTestFlightInternalTestingOnly(exportOpts, testFlightInternalTestingOnly)
}
}

return exportOpts, nil
}

Expand Down Expand Up @@ -381,6 +388,16 @@ func addTeamID(exportOpts exportoptions.ExportOptions, teamID string) exportopti
return exportOpts
}

func addTestFlightInternalTestingOnly(exportOpts exportoptions.ExportOptions, testFlightInternalTestingOnly bool) exportoptions.ExportOptions {
switch options := exportOpts.(type) {
case exportoptions.AppStoreOptionsModel:
options.TestFlightInternalTestingOnly = testFlightInternalTestingOnly // Only available for app-store exports
return options
}

return exportOpts
}

func addManualSigningFields(exportOpts exportoptions.ExportOptions, codeSignGroup *export.IosCodeSignGroup, archivedWithXcodeManagedProfiles bool, logger log.Logger) exportoptions.ExportOptions {
exportCodeSignStyle := ""
exportProfileMapping := map[string]string{}
Expand Down
53 changes: 43 additions & 10 deletions exportoptionsgenerator/exportoptionsgenerator_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -167,13 +167,14 @@ func TestExportOptionsGenerator_GenerateApplicationExportOptions_ForAutomaticSig
logger.EnableDebugLog(true)

tests := []struct {
name string
generatorFactory func() ExportOptionsGenerator
exportMethod exportoptions.Method
containerEnvironment string
xcodeVersion int64
want string
wantErr bool
name string
generatorFactory func() ExportOptionsGenerator
exportMethod exportoptions.Method
containerEnvironment string
xcodeVersion int64
testFlightInternalTestingOnly bool
want string
wantErr bool
}{
{
name: "Default development exportOptions",
Expand Down Expand Up @@ -264,13 +265,45 @@ func TestExportOptionsGenerator_GenerateApplicationExportOptions_ForAutomaticSig
<key>teamID</key>
<string>TEAM123</string>
</dict>
</plist>`,
},
{
name: "When exporting for TestFlight internal testing only",
exportMethod: exportoptions.MethodAppStore,
xcodeVersion: 15,
testFlightInternalTestingOnly: true,
generatorFactory: func() ExportOptionsGenerator {
applicationTarget := givenApplicationTarget(nil)
xcodeProj := givenXcodeproj([]xcodeproj.Target{applicationTarget})
scheme := givenScheme(applicationTarget)

g := New(&xcodeProj, &scheme, "", logger)
g.targetInfoProvider = MockTargetInfoProvider{
bundleID: map[string]string{"Application": bundleID},
}

return g
},
want: `<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>manageAppVersionAndBuildNumber</key>
<false/>
<key>method</key>
<string>app-store</string>
<key>teamID</key>
<string>TEAM123</string>
<key>testFlightInternalTestingOnly</key>
<true/>
</dict>
</plist>`,
},
}
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
// Act
gotOpts, err := tt.generatorFactory().GenerateApplicationExportOptions(tt.exportMethod, tt.containerEnvironment, teamID, true, true, false, exportoptions.SigningStyleAutomatic, tt.xcodeVersion)
gotOpts, err := tt.generatorFactory().GenerateApplicationExportOptions(tt.exportMethod, tt.containerEnvironment, teamID, true, true, false, exportoptions.SigningStyleAutomatic, tt.xcodeVersion, tt.testFlightInternalTestingOnly)

// Assert
require.NoError(t, err)
Expand Down Expand Up @@ -372,7 +405,7 @@ func TestExportOptionsGenerator_GenerateApplicationExportOptions(t *testing.T) {
}

// Act
gotOpts, err := g.GenerateApplicationExportOptions(tt.exportMethod, "Production", teamID, true, true, false, exportoptions.SigningStyleManual, tt.xcodeVersion)
gotOpts, err := g.GenerateApplicationExportOptions(tt.exportMethod, "Production", teamID, true, true, false, exportoptions.SigningStyleManual, tt.xcodeVersion, true)

// Assert
require.NoError(t, err)
Expand Down Expand Up @@ -442,7 +475,7 @@ func TestExportOptionsGenerator_GenerateApplicationExportOptions_WhenNoProfileFo
}

// Act
gotOpts, err := g.GenerateApplicationExportOptions(tt.exportMethod, "Production", teamID, true, true, false, exportoptions.SigningStyleManual, tt.xcodeVersion)
gotOpts, err := g.GenerateApplicationExportOptions(tt.exportMethod, "Production", teamID, true, true, false, exportoptions.SigningStyleManual, tt.xcodeVersion, true)

// Assert
require.NoError(t, err)
Expand Down
43 changes: 19 additions & 24 deletions go.mod
Original file line number Diff line number Diff line change
@@ -1,64 +1,60 @@
module github.com/bitrise-io/go-xcode/v2

go 1.21
go 1.22

toolchain go1.23.2

require (
cloud.google.com/go/secretmanager v1.14.2
cloud.google.com/go/storage v1.48.0
cloud.google.com/go/secretmanager v1.14.3
cloud.google.com/go/storage v1.50.0
github.com/bitrise-io/go-steputils v1.0.5
github.com/bitrise-io/go-steputils/v2 v2.0.0-alpha.18
github.com/bitrise-io/go-utils v1.0.12
github.com/bitrise-io/go-utils/v2 v2.0.0-alpha.23
github.com/bitrise-io/go-xcode v1.1.1
github.com/bitrise-io/go-xcode v1.1.2
github.com/golang-jwt/jwt/v4 v4.5.0
github.com/google/go-querystring v1.1.0
github.com/hashicorp/go-retryablehttp v0.7.7
github.com/hashicorp/go-version v1.6.0
github.com/ryanuber/go-glob v1.0.0
github.com/stretchr/testify v1.9.0
github.com/stretchr/testify v1.10.0
golang.org/x/oauth2 v0.24.0
golang.org/x/text v0.20.0
google.golang.org/api v0.210.0
golang.org/x/text v0.21.0
google.golang.org/api v0.214.0
howett.net/plist v1.0.0
)

require (
cel.dev/expr v0.16.1 // indirect
cloud.google.com/go v0.116.0 // indirect
cloud.google.com/go/auth v0.11.0 // indirect
cloud.google.com/go/auth v0.13.0 // indirect
cloud.google.com/go/auth/oauth2adapt v0.2.6 // indirect
cloud.google.com/go/compute/metadata v0.5.2 // indirect
cloud.google.com/go/compute/metadata v0.6.0 // indirect
cloud.google.com/go/iam v1.2.2 // indirect
cloud.google.com/go/monitoring v1.21.2 // indirect
github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp v1.24.1 // indirect
github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp v1.25.0 // indirect
github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/metric v0.48.1 // indirect
github.com/GoogleCloudPlatform/opentelemetry-operations-go/internal/resourcemapping v0.48.1 // indirect
github.com/bitrise-io/go-pkcs12 v0.0.0-20230815095624-feb898696e02 // indirect
github.com/bitrise-io/go-plist v0.0.0-20210301100253-4b1a112ccd10 // indirect
github.com/census-instrumentation/opencensus-proto v0.4.1 // indirect
github.com/cespare/xxhash/v2 v2.3.0 // indirect
github.com/cncf/xds/go v0.0.0-20240905190251-b4127c9b8d78 // indirect
github.com/davecgh/go-spew v1.1.1 // indirect
github.com/envoyproxy/go-control-plane v0.13.0 // indirect
github.com/envoyproxy/go-control-plane/envoy v1.32.3 // indirect
github.com/envoyproxy/protoc-gen-validate v1.1.0 // indirect
github.com/felixge/httpsnoop v1.0.4 // indirect
github.com/fullsailor/pkcs7 v0.0.0-20190404230743-d7302db945fa // indirect
github.com/go-logr/logr v1.4.2 // indirect
github.com/go-logr/stdr v1.2.2 // indirect
github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect
github.com/google/go-cmp v0.6.0 // indirect
github.com/google/s2a-go v0.1.8 // indirect
github.com/google/uuid v1.6.0 // indirect
github.com/googleapis/enterprise-certificate-proxy v0.3.4 // indirect
github.com/googleapis/gax-go/v2 v2.14.0 // indirect
github.com/hashicorp/go-cleanhttp v0.5.2 // indirect
github.com/kr/pretty v0.3.1 // indirect
github.com/pkg/errors v0.9.1 // indirect
github.com/planetscale/vtprotobuf v0.6.1-0.20240319094008-0393e58bdf10 // indirect
github.com/pmezard/go-difflib v1.0.0 // indirect
github.com/rogpeppe/go-internal v1.10.0 // indirect
github.com/stretchr/objx v0.5.2 // indirect
go.opencensus.io v0.24.0 // indirect
go.opentelemetry.io/contrib/detectors/gcp v1.29.0 // indirect
Expand All @@ -69,17 +65,16 @@ require (
go.opentelemetry.io/otel/sdk v1.29.0 // indirect
go.opentelemetry.io/otel/sdk/metric v1.29.0 // indirect
go.opentelemetry.io/otel/trace v1.29.0 // indirect
golang.org/x/crypto v0.29.0 // indirect
golang.org/x/net v0.31.0 // indirect
golang.org/x/sync v0.9.0 // indirect
golang.org/x/sys v0.27.0 // indirect
golang.org/x/term v0.26.0 // indirect
golang.org/x/crypto v0.31.0 // indirect
golang.org/x/net v0.33.0 // indirect
golang.org/x/sync v0.10.0 // indirect
golang.org/x/sys v0.28.0 // indirect
golang.org/x/term v0.27.0 // indirect
golang.org/x/time v0.8.0 // indirect
google.golang.org/genproto v0.0.0-20241118233622-e639e219e697 // indirect
google.golang.org/genproto/googleapis/api v0.0.0-20241113202542-65e8d215514f // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20241118233622-e639e219e697 // indirect
google.golang.org/grpc v1.67.2 // indirect
google.golang.org/grpc/stats/opentelemetry v0.0.0-20240907200651-3ffb98b2c93a // indirect
google.golang.org/genproto/googleapis/api v0.0.0-20241118233622-e639e219e697 // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20241209162323-e6fa225c2576 // indirect
google.golang.org/grpc v1.67.3 // indirect
google.golang.org/protobuf v1.35.2 // indirect
gopkg.in/yaml.v3 v3.0.1 // indirect
)
Loading