Ssw 2880 profile paths dedup#316
Merged
Merged
Conversation
…rnPath() and ProvisioningProfilesDirLegacyPath() for reusable way to get provisioning profile dirs feat: Added IOSExtension and MacExtension refactor: removed some duplication in listing logic
godrei
approved these changes
Mar 10, 2026
| if err != nil { | ||
| return nil, "", err | ||
| } | ||
| macOSPaths, err := listProfiles(ProfileTypeMacOs, uuid) |
Contributor
There was a problem hiding this comment.
NIT: the previous logic returned early, we could do the same here, if an ios profile found let's return it and don't do the macos profile search unnecessarily.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: Added ProvisioningProfilesDirPath() ProvisioningProfilesDirModernPath() and ProvisioningProfilesDirLegacyPath() for reusable way to get provisioning profile dirs
feat: Added IOSExtension and MacExtension
refactor: removed some duplication in listing logic
Integrated with xcode-archive: bitrise-steplib/steps-xcode-archive#416