Adding flaky test with persistent state #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpusok
force-pushed
the
STEP-1054-test-run-retry
branch
from
9d95dac to
9cbd488
Compare
lpusok
force-pushed
the
STEP-1054-test-run-retry
branch
from
9cbd488 to
3c856ad
Compare
lpusok
force-pushed
the
STEP-1054-test-run-retry
branch
from
3c856ad to
7bbac04
Compare
lpusok
force-pushed
the
STEP-1054-test-run-retry
branch
from
99149fb to
56f3072
Compare
Bence1001
previously approved these changes
Jul 5, 2021
Contributor
Bence1001
left a comment
Bence1001
left a comment
There was a problem hiding this comment.
Generally LGTM, I only have two remarks.
lpusok
changed the title
Bence1001
approved these changes
Jul 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Adding test that fails a given times, then suceeds. The number of failures is stored persistently, in the Simulator user defaults.
Resolves: https://bitrise.atlassian.net/browse/STEP-1054
Decisions
Used User defaults instead of a file for future compatibility.