Check output tool and install Xcpretty if it is missing #115
Conversation
Squashed commits: [31f5a78] clean
| - path::./: | ||
| inputs: | ||
| - output_tool: xcodebuild | ||
| - output_tool: $OUTPUT_TOOL |
There was a problem hiding this comment.
OUTPUT_TOOL is set to xcpretty (which is the default value for this input) please wire in test for xcodebuild output tool
There was a problem hiding this comment.
The test_objc workflow using the xcodebuild as an output tool.
main.go
Outdated
| } | ||
| } | ||
|
|
||
| if err == nil { |
main.go
Outdated
| log.Printf("Switching to xcodebuild for output tool") | ||
| outputTool = "xcodebuild" | ||
| } | ||
| log.Printf("- xcprettyVersion: %s", xcprettyVersion.String()) |
There was a problem hiding this comment.
do this after you made sure that xcpretty is available or switched to xcodebuild (if outputtool == xcpretty {...)
step.yml
Outdated
| - xcodebuild | ||
| is_required: true | ||
| is_expand: false | ||
| is_expand: true |
There was a problem hiding this comment.
this is the default value, pls remove
| } | ||
|
|
||
| // IsToolInstalled ... | ||
| func IsToolInstalled(name string) bool { |
There was a problem hiding this comment.
was it only used for xcpretty?
utils/utils.go
Outdated
| cmd := command.New("which", name) | ||
| out, err := cmd.RunAndReturnTrimmedCombinedOutput() | ||
| return err == nil && out != "" | ||
| func IsToolInstalled(name, version string) (bool, error) { |
There was a problem hiding this comment.
do we need this at all? it just wraps a single line of command
utils/utils.go
Outdated
| func InstallXcpretty() error { | ||
| cmds, err := rubycommand.GemInstall("xcpretty", "") | ||
| if err != nil { | ||
| return fmt.Errorf("failed to create command model, error: %s", err) |
There was a problem hiding this comment.
failed to create %s install command, xcpretty
utils/utils.go
Outdated
| } | ||
|
|
||
| for _, cmd := range cmds { | ||
| log.Donef("$ %s", cmd.PrintableCommandArgs()) |
There was a problem hiding this comment.
do not use green coloring, this is just a small utility, but not a big milestone in the step, like other Done logs
godrei
left a comment
godrei
left a comment
There was a problem hiding this comment.
pls have a look at my comments
Squashed commits: [014f40e] PR clean - fix
BirmacherAkos
force-pushed
the
check_output_tool
branch
from
db606f8 to
167c8a0
Compare
No description provided.