fix uuidv7 in nodejs v18#3
Closed
MSITETOP wants to merge 5 commits into
Closed
Conversation
Collaborator
|
Thank you. |
This reverts commit b82826d.
IgorShevchik
pushed a commit
that referenced
this pull request
May 24, 2026
Five-angle review (docs, programmer, QA, security, CTO — each a sub-agent on Sonnet) surfaced 30+ findings across the agent-facing docs. Apply them all in this PR per the project's "fix-it-here" direction. Major: - Delete CLAUDE.md; absorb its unique content (Architecture, Documentation Upkeep, Git Workflow, webhook scopes, *.unit.spec.ts exception, the hidden `main` scope detail) into AGENTS.md so the project has a single source of truth for agents. README-AI.md stays but is marked as transitional in the Resources section (to be removed by future PRs). - AGENTS.md: add `Adding a REST Method to an Existing Action` lightweight checklist alongside the existing New Surface workflow (CTO #1). Extend PR Review Checklist with frame / helper / B24Hook-specific items (CTO #4). Add Before Submitting bullet about updating contributing guides when patterns change (CTO #6). Add a conflict-resolution note in Resources (CTO #2). - package-structure.md: manager template now uses `protected` (matches AbstractHelper.ts:15), references abstract-helper.ts as the canonical base (not helper-manager.ts which is an aggregator). Deprecation guidance now covers all three required pieces (JSDoc + LoggerFactory .forcedLog + minor-release overlap). B24Hook browser warning is now imperative ("MUST NOT", "do not suppress offClientSideWarning"). - transports-and-results.md: Logger Discipline gains a Credential Redaction subsection covering redact.ts, the URL-in-path secret risk for B24Hook, and SdkError-doesn't-take-secrets rule. hardErrorCodes doc reframed to "HTTP 2xx domain codes only" — HTTP 4xx is already auto-non-retry per RestrictionManager.isClientError. ParamsFactory preset table no longer hardcodes numeric values (drift risk). v3 URL pattern added. "Adding a New Transport Action" converted to checklist. v2.0.0 hard-coded version replaced with reference to @removed tag. - testing.md: webhook scopes section added (crm/tasks/user/im/main, including the hidden `main` scope note). *.unit.spec.ts exception documented as a narrow exception with rationale. Under-load preset corrected to getBatchProcessing(). Under-load setup file pointer added (hooks-under-load-jssdk.ts, not hooks-integration-jssdk.ts). some-code-from-docs is no longer claimed as compile-checked — honest "manual reference" wording with #49 cross-link. Explicit "CI does not run Vitest" note. .env.test "never commit" rule. Webhook URL placeholder rewritten to YOUR_USER_ID/YOUR_WEBHOOK_SECRET. Rule against secrets in requestId/code/description. - documentation.md: example URL in code-example block now uses YOUR_USER_ID/YOUR_WEBHOOK_SECRET placeholders with a "read from env, never hard-code" comment. Deliberately not done: - Sentence-case rewrite of headings across AGENTS.md and .github/ contributing/*.md (D1/D7/D8/D10): the sentence-case rule in documentation.md is scoped to the docs site (`docs/content/docs/`), not to agent-facing guides. The b24ui AGENTS.md this PR models from uses Title Case as well. - CTO #5 (downgrade #49 from blocker): explicitly retained as blocker per prior decision. - CTO #3 (CI check for .md file paths): out of scope here; will file as a separate non-blocker issue after merge.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2