feat(ContentSearch/DashboardSearch): support unmountOnHide prop (#6523)#217
Merged
Conversation
Port of upstream nuxt/ui f03f98ba. Surfaces the Modal unmountOnHide prop through the search wrappers (builds on 1ea8a98f / #214): - DashboardSearch.vue + content/ContentSearch.vue: add unmountOnHide to the Pick<ModalProps> interface and to the modalProps reactivePick. - docs app/components/search/Search.vue: pass :unmount-on-hide=false. Direct 1:1 (b24ui matched the pre-change). Prop pass-through; no snapshot churn. Ledger: record the merge sha for the previous no-op markers (#216, 54125f3f) and advance the sync cursor to f03f98ba. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Qz7EXMncvEGiCj4WbmYgJo
IgorShevchik
added a commit
that referenced
this pull request
Jun 25, 2026
…ent (#6628) (#218) Port of upstream nuxt/ui d3b5f1d3. Components that conditionally render an inner link (when `to` is set) only spread $attrs onto that link; with inheritAttrs: false, attrs went nowhere when there was no `to`. Bind v-bind="!props.to ? $attrs : {}" on the root so attrs land on the root without a link and on the link with one. - Banner, PageFeature, User, prose/Callout, prose/Card: add the conditional v-bind on the root element. - PageCard: b24ui's root already bound v-bind="$attrs" unconditionally (a fork divergence that double-applied attrs with `to`); made it conditional. - Tests: +attr-forwarding cases on Banner/PageCard/PageFeature/User specs; new prose/Callout.spec.ts + prose/Card.spec.ts. - BlogPost / ChangelogVersion are N/A (absent in b24ui). - PageFeature/User Primitive reflowed multiline (max-attributes-per-line). Ledger: record the merge sha for the previous port (#217, f03f98ba) and advance the sync cursor to d3b5f1d3 (= upstream/v4 HEAD: sync caught up). Claude-Session: https://claude.ai/code/session_01Qz7EXMncvEGiCj4WbmYgJo Co-authored-by: Shevchik Igor <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of upstream nuxt/ui
f03f98ba—feat(ContentSearch/DashboardSearch): support unmountOnHide prop (#6523). Builds on the ModalunmountOnHidesupport added in #214.Change
DashboardSearch.vue/content/ContentSearch.vue: add'unmountOnHide'to thePick<ModalProps, …>interface and to themodalPropsreactivePick.app/components/search/Search.vue: pass:unmount-on-hide="false".Direct 1:1 — b24ui matched the upstream pre-change shape.
Verification (pnpm 11.8.0, gate ON)
dev:prepare · lint · typecheck · test (5117 passed, 6 skipped) · module build — all green. Prop pass-through; no snapshot churn.
Ledger: records the merge sha for the previous no-op markers (#216,
54125f3f) and advances the sync cursor tof03f98ba.https://claude.ai/code/session_01Qz7EXMncvEGiCj4WbmYgJo
🤖 Generated with Claude Code
Generated by Claude Code