Fix 4-bit quantization for weight matrices not divisible by blocksize#1884
Merged
matthewdouglas merged 3 commits intobitsandbytes-foundation:mainfrom Mar 3, 2026
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Triton 4-bit quantization kernels assume the total number of elements is evenly divisible by
blocksize. When this doesn't hold, the last block is partially filled with uninitialized data, which corrupts theabsmaxscaling factor for that block.This PR fixes the issue by padding the input tensor with zeros to the next multiple of
blocksizebefore entering the kernel. The padding is purely internal toquantize_4bit; the output tensor and dequantization path use the original shape, so callers are unaffected. Zero-padding has no impact onabsmaxaccuracy sincemax(abs(...))is unaffected by additional zeros.A roundtrip test is added to verify quantize/dequantize works correctly with non-divisible shapes and produces no NaN or Inf values.