remove deprecated tests#1922
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
|
||
| @pytest.mark.parametrize("dim1", [2048, 4096], ids=id_formatter("dim1")) | ||
| @pytest.mark.parametrize("dim2", [512, 1024], ids=id_formatter("dim2")) | ||
| def test_int8_double_quant(self, dim1, dim2): |
There was a problem hiding this comment.
This is the main one where I hesitate because we may still have external users calling int8_double_quant - even if they're not actually training int8 weights.
There's a tip in the docs about this but this is one where we haven't emitted deprecation warnings on either.
<Tip>
This function is useful for training, but for inference it is advised to use [`int8_vectorwise_quant`] instead.
This implementation performs additional column-wise transposed calculations which are not optimized.
</Tip>
My ask here is that for now we change this one to only test on CUDA and give this one a short deprecation cycle before removing. This test doesn't necessarily assume int8 training and I believe is our only coverage on the op.
|
I'm not fundamentally opposed to removing these tests as we generally either don't run them, or would be unlikely to take action on them if they did fail. The main hesitation is that we haven't gone through a deprecation cycle on some of these. Particularly As for the rest, considering I was planning to start emitting deprecation warnings for all of those features specifically before we push out v0.50.0, I think they are OK. |
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
|
Hi @matthewdouglas . I have added |
ca90fe4
into
bitsandbytes-foundation:main
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
This PR removes deprecated test coverage to reduce noise and avoid generating cases that are intentionally unsupported.
Changes
tests/test_autograd.pyreq_grad[1] == Truefortest_matmullt.tests/test_linear8bitlt.pytest_linear_serializationto non-deprecatedhas_fp16_weights=False.has_fp16_weights=Truecombinations.tests/test_modules.pytests/test_functional.pyImpact