fix(tests): wait for appended reply before asserting order#40
Merged
tomcasaburi merged 1 commit intomasterfrom Mar 19, 2026
Merged
fix(tests): wait for appended reply before asserting order#40tomcasaburi merged 1 commit intomasterfrom
tomcasaburi merged 1 commit intomasterfrom
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe test case for Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Low risk: test-only change that makes an async ordering assertion more deterministic, without affecting production logic.
Overview
Updates
src/hooks/replies.test.tsto make thescroll pages append and publishtest less flaky by waiting until the appended account reply is present in its expected position (length andcid) before asserting reply ordering.Written by Cursor Bugbot for commit aeb7e6b. This will update automatically on new commits. Configure here.
Summary by CodeRabbit