Failures in recipes do not lead to build aborts

[andresailer]

Investigated with @m-fol

bits/bits_helpers/build_template.sh

Line 210 in cba3427

source "$WORK_DIR/SPECS/$PKGPATH/$PKGNAME.sh" && [[ $(type -t Run) == function ]] && Run $* ;

introduced in 7b7ef02

This construct swallows many failures that can happen in recipes, things like exit 1 would work to abort, but adding this to the recipes seems rather invasive.

I.e., we have a problem during the ROOT cmake configuration, but bits happily continues claiming ROOT built successfully.

For example consider this package recipe

package: packA
version: "0.0.1"
tag: "v0.0.1"
---
#!/bin/bash -e

set -x
set -e
echo "PackA IS BUILDING"
false
echo "The previous check should lead to failure. PackA didn't exit."

bits build packA

will claim success, even if the ls (or cmake, or whatever) fails.

[pbuncic]

You are right, and the blame is on me. Please try it again now from the main branch.