Skip to content

Conversation

@chriscarter90
Copy link
Contributor

@chriscarter90 chriscarter90 commented Dec 20, 2017

Summary of changes

Fixes #404.

Updates the RO translation files (which contain plurals) to accurately represent a third case. This case is for any number ending in 00, or 20-99, as shown at https://www.gnu.org/software/gettext/manual/html_node/Plural-forms.html#Plural-forms.

Checklist

  • Plural translations have been updated
  • Commits were squashed into a single coherent commit

@coveralls
Copy link

coveralls commented Dec 20, 2017

Coverage Status

Coverage remained the same at 67.999% when pulling f385440 on chriscarter90:master into 0a736dc on bitwalker:master.

@coveralls
Copy link

coveralls commented Dec 20, 2017

Coverage Status

Coverage remained the same at 67.999% when pulling 880babc on chriscarter90:master into 0a736dc on bitwalker:master.

@elenatanasoiu
Copy link

Romanian here: this is accurate.

@bartoszgorka
Copy link

@bitwalker can you merge this fix?

@nathanhornby
Copy link

Please merge 🙏

msgid_plural "%{count} years"
msgstr[0] "%{count} an"
msgstr[1] "%{count} ani"
msgstr[2] "%{count} ani"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chriscarter90 Would this not be %{count} de ani as well?

@MeerKatDev
Copy link

I currently have the same problem still (I started to notice it exactly 8 days ago), is it fixed? How to get around it for the moment?

@bitwalker bitwalker merged commit f134ec8 into bitwalker:master Jan 30, 2018
@bitwalker
Copy link
Owner

Sorry for the delay everyone, I've been busier than I would like :(

@MeerKatDev
Copy link

Sorry, maybe a newbie question, but I cleaned the deps from that, then did deps.get again and compiled, but I still get the same error. How do I get the library with this fix?

@goofansu
Copy link

@MeerKatDev

You should unlock the dep first.

mix deps.unlock timex
mix deps.get

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants