[KnownUsernameField] Engine update (make the system more flexible)#1011
[KnownUsernameField] Engine update (make the system more flexible)#1011cscharf merged 5 commits intobitwarden:masterfrom contribucious:KnownUsernameField--engine-update--flexibility
Conversation
|
When you have some time @mportune-bw, could you take a look at this slight update of your system? My next PR is already ready @ local side (big update of entries). Thanks! |
|
@contribucious , is there a chance you can refactor a little bit using Tuples or actual types vs. multidimensional arrays ( |
|
Hello @cscharf, Sorry for the delay. You are right. Is it better now? Note: Compiles successfully and is functional in practice (APK installed and tested). |
|
@cscharf Is last week's change OK for you? |
cscharf
left a comment
There was a problem hiding this comment.
Just one question/open comment and then yes, we should be good.
|
You're welcome. 👍 |
CONTEXT: This is an update of this new system (system allowing "user ID" field detection — i.e. email/username/phone/whatever — without "password" field using the accessibility service).
UPDATED: Engine.
↪️ Prerequisite for my next PR which concerns the entries.
This:
allows to have multiple pairs "path / username view ID" per domain;
adds more advanced path support:
startswith:string,contains:string,endswith:stringandistartswith:string,icontains:string,iendswith:string.💡 About using
StringComparison.OrdinalandStringComparison.OrdinalIgnoreCase, this is recommended for a variety of reasons including better performance. See the page Best Practices for Using Strings in .NET from Microsoft documentation.