Modified listing of website from Hostname to Host#1012
Merged
MattTheDev merged 2 commits intomasterfrom Jul 14, 2020
Merged
Conversation
kspearrin
previously approved these changes
Jul 14, 2020
cscharf
approved these changes
Jul 14, 2020
vvolkgang
pushed a commit
that referenced
this pull request
Jun 20, 2024
vvolkgang
pushed a commit
that referenced
this pull request
Jun 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Modify listing of URI to include port where applicable. Aligns with changes in jslib.
Code Changes
src/Core/Models/View/LoginUriView.cs View model changes. Hostname was no longer being used with this change, so replace Hostname with Host.
src/App/Pages/Vault/ViewPage.xaml Presentation modification. Point to new property.