Skip to content

[SSO] New user provision flow#1091

Merged
vincentsalucci merged 2 commits intomasterfrom
m-user-provision
Oct 13, 2020
Merged

[SSO] New user provision flow#1091
vincentsalucci merged 2 commits intomasterfrom
m-user-provision

Conversation

@vincentsalucci
Copy link
Member

Objective

Currently, when a new bitwarden/org user is created, they are given a status of accepted. This can create issues for organizations trying to confirm the same user (which can't happen until they've set their master password). To alleviate the issue, change new user's orgUser status to invited until after they've set a master password. Pass through the necessary information for the 2fa and set-password components.

Code Changes

  • LoginSsoPage.xaml.cs: Passed already existing _vm.orgIdentifier into the constructor for both the 2fa and SetPassword pages.
  • SetPasswordPage.xaml.cs: Added orgIdentifier to the constructor. Saved parameter value to the underlying view model.
  • SetPasswordPageViewModel.cs: Created OrgIdentifier property and assigned value to the SetPasswordRequest OrgIdentifier field.
  • TwoFactorPage.xaml.cs: Added orgIdentifier to the constructor and created member variable for passing along the result to the SetPasswordPage
  • SetPasswordRequest.cs: Added OrgIdentifier string to the request object.

@vincentsalucci
Copy link
Member Author

Merged from master because this branch was over 2 weeks stale.

@vincentsalucci vincentsalucci requested a review from mpbw2 October 11, 2020 22:20
@vincentsalucci vincentsalucci merged commit e72ccaf into master Oct 13, 2020
@vincentsalucci vincentsalucci deleted the m-user-provision branch October 13, 2020 20:01
vvolkgang pushed a commit that referenced this pull request Jun 20, 2024
vvolkgang pushed a commit that referenced this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants