Merged
Conversation
mpbw2
previously approved these changes
Dec 8, 2020
mpbw2
approved these changes
Dec 14, 2020
vvolkgang
pushed a commit
that referenced
this pull request
Jun 20, 2024
vvolkgang
pushed a commit
that referenced
this pull request
Jun 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Code Changes
PolicyServiceto constructor. Added logic during construction of personal ownership list to remove the personal ownership option if necessary. Note: ran into a special use case where the list of collections was not being updated when defaulting to an organization because of the personal ownership policy. If theOwnershipOrgIndexremained at position 0, the change detection would not occur: Forced a refresh if specific condition met. Added check during submit to make sure the user didn't select personal ownership when not available.PersonalOwnershippolicy typeUsePoliciesUsePoliciesUsePoliciesScreenshots