Skip to content

[Policy] Personal Ownership#1166

Merged
vincentsalucci merged 6 commits intomasterfrom
m-personal-ownership
Dec 14, 2020
Merged

[Policy] Personal Ownership#1166
vincentsalucci merged 6 commits intomasterfrom
m-personal-ownership

Conversation

@vincentsalucci
Copy link
Member

@vincentsalucci vincentsalucci commented Dec 4, 2020

Objective

Allow organizations to restrict user's from saving added/cloned items to their personal vaults. Remove the personal ownership option when this policy is enabled and the user is not an Admin/Owner of the organization.

Code Changes

  • Android/AutofillService: Added checks to prevent user's from being able to auto-fill/save new logins (defaults to personal ownership, otherwise)
  • AddEditPageViewModel: Added PolicyService to constructor. Added logic during construction of personal ownership list to remove the personal ownership option if necessary. Note: ran into a special use case where the list of collections was not being updated when defaulting to an organization because of the personal ownership policy. If the OwnershipOrgIndex remained at position 0, the change detection would not occur: Forced a refresh if specific condition met. Added check during submit to make sure the user didn't select personal ownership when not available.
  • AppResource: Added error message
  • PolicyType: Added PersonalOwnership policy type
  • OrganizationData: Added UsePolicies
  • Organization: Added UsePolicies
  • ProfileOrganizationResponse: Added UsePolicies

Screenshots

0-list
1-error

mpbw2
mpbw2 previously approved these changes Dec 8, 2020
@vincentsalucci vincentsalucci requested a review from mpbw2 December 13, 2020 18:08
@vincentsalucci vincentsalucci marked this pull request as ready for review December 13, 2020 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants