Conversation
cscharf
reviewed
Feb 18, 2021
cscharf
approved these changes
Feb 18, 2021
vvolkgang
pushed a commit
that referenced
this pull request
Jun 20, 2024
vvolkgang
pushed a commit
that referenced
this pull request
Jun 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Added support for disabling Send via enterprise policy. Functionality is reduced to read and delete only.
(Note that references to "options button" below is referring to the 3-dot overflow for each item in listviews, not the new expandable options button on the Send Add/Edit page)
Files Changes/Added
Android:
App:
SendEnabled(also tweaked button size for android hack and added missing "Async" suffix to "TypeChanged" method)SendEnabledproperty, made init method async, addedSendEnabledcheck failsafe toSubmitAsync, useCopySendUrlAsynchelper method, added missingAsyncsuffix toShareSendUrlSendEnabledpropertySendLinkandSendDisabledWarningtextIsSendDisabledByPolicyAsyncandCopySendUrlAsynchelper methods, and addedIsSendDisabledByPolicyAsyncfailsafe checks toShareSendUrlAsyncandRemoveSendPasswordAsyncCore:
DisableSendpolicy typeConsiderations
Screenshots