Skip to content

Send file model changes#1293

Merged
MGibson1 merged 2 commits intomasterfrom
send-file-model-changes
Mar 2, 2021
Merged

Send file model changes#1293
MGibson1 merged 2 commits intomasterfrom
send-file-model-changes

Conversation

@MGibson1
Copy link
Member

@MGibson1 MGibson1 commented Mar 1, 2021

Overview

Related to bitwarden/server#1175. Updates models to match new expected lack of URL in SendFile and file length hint in SendRequest.

Files Changed

  • SendFileApi.cs/SendFileData.cs/SendFile.cs/SendFileView.cs: Remove Url
  • SendRequest.cs/SendService.csc Add and populate FileLength hint on initial Send Request
  • Tests: Populate File Length. Verifies SendRequest file length is correctly populated.

@MGibson1 MGibson1 requested a review from a team March 1, 2021 23:18
@MGibson1 MGibson1 merged commit 2c13cef into master Mar 2, 2021
@MGibson1 MGibson1 deleted the send-file-model-changes branch March 2, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants