Fix for incorrect deletion/expiration times during Send creation#1313
Merged
Fix for incorrect deletion/expiration times during Send creation#1313
Conversation
cscharf
approved these changes
Mar 12, 2021
cscharf
left a comment
cscharf
left a comment
There was a problem hiding this comment.
Seems to work as I look at it, agree it's not that elegant but the logic seems to work in my head as I follow it through.
vvolkgang
pushed a commit
that referenced
this pull request
Jun 20, 2024
vvolkgang
pushed a commit
that referenced
this pull request
Jun 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating a new Send, the DateTimes created from the "simple" picker were being set to midnight instead of the current time. Not really a showstopper until "one hour" is selected, resulting in a DateTime from the past ([today] at midnight). Some investigation revealed that modifying the 'DeletionDate' property bound to
ExtendedDatePickerwas triggering property changes multiple times within the picker and resetting the time to midnight. Those custom pickers are no fun, so for safety/sanity during this release I've given the "simple" pickers their own "simple" DateTimes to modify, isolating them from the values bound to the custom pickers. I will revisit this later to come up with something more elegant.Edit: Forgot to mention also fixed a missing "Send" capitalization