Update ios Autofill page to match setting's name#1354
Merged
vvolkgang merged 1 commit intobitwarden:masterfrom Mar 18, 2022
Merged
Update ios Autofill page to match setting's name#1354vvolkgang merged 1 commit intobitwarden:masterfrom
vvolkgang merged 1 commit intobitwarden:masterfrom
Conversation
The option in the ios menu to get to autofill settings is called "Passwords" instead of "Passwords & Accounts"
|
|
just-hash
approved these changes
Apr 3, 2021
cscharf
previously requested changes
Apr 5, 2021
cscharf
left a comment
cscharf
left a comment
There was a problem hiding this comment.
This change assumes the latest version of iOS, for those still using <= iOS 13 it is still labeled, "Passwords & Accounts" as noted here.
Perhaps a more appropriate change would consider the user's iOS version before changing the verbiage here.
Member
|
Hi @jnolan912, I'm reviewing old PRs. Are you still interested in progressing this one or should it be closed? I'm happy to wait if you're coming back to it, just wanted to check. |
@eliykat 85% of all devices and 90% of those released in the past 4 years have adopted iOS 14. I'd say it's not inappropriate to consider merging this. |
vvolkgang
approved these changes
Mar 18, 2022
vvolkgang
pushed a commit
that referenced
this pull request
Jun 20, 2024
vvolkgang
pushed a commit
that referenced
this pull request
Jun 20, 2024
SaintPatrck
added a commit
that referenced
this pull request
Mar 4, 2025
Update mockk from 1.13.13 to 1.13.17 <details> <summary>mockk/mockk (io.mockk:mockk)</summary> ### p`v1.13.17`](https://redirect.github.com/mockk/mockk/releases/tag/1.13.17) [Compare Source](mockk/mockk@1.13.16...1.13.17) ##### What's Changed - Fix(Issue #1333): Bug fix for the issue with MockK 1.13.16 Wraps Results Objects Twice by @kpadhiamex in [#1334](mockk/mockk#1334) - Fix (issue# 1329) parallel testing for unmockkAll by @kpadhiamex in [#1335](mockk/mockk#1335) - [[#1304]](mockk/mockk#1304) feat: Restrict mocking of certain classes and add configuration option by @devtaebong in [#1340](mockk/mockk#1340 - Update README.md - Clarify that private fields cannot be mocked by @p4ulor in [#1347](mockk/mockk#1347) - Added new property "failOnSetBackingFieldException" to fail test if a backing field could not be set by @cgm-aw in [#1349](mockk/mockk#1349) - Fix compilation error in constructedWith docs by @TWiStErRob in [#1354](mockk/mockk#1354) **Full Changelog: **Full Changelog**: mockk/mockk@1.13.16...1.13.17 ### [`v1.13.16`](https://redirect.github.com/mockk/mockk/releases/tag/1.13.16) [Compare Source](https://redirect.github.com/mockk/mockk/compare/1.13.14...1.13.16) ##### What's Changed - Fix( Issue [#​1073](https://redirect.github.com/mockk/mockk/issues/1073)): Bug fix for the issue with mocking value classes with coEvery by [@​kpadhiamex](https://redirect.github.com/kpadhiamex) in [https://github.com/mockk/mockk/pull/1332](https://redirect.github.com/mockk/mockk/pull/1332) **Full Changelog**: mockk/mockk@1.13.14...1.13.16 ### [`v1.13.14`](https://redirect.github.com/mockk/mockk/releases/tag/1.13.14) [Compare Source](https://redirect.github.com/mockk/mockk/compare/1.13.13...1.13.14) ##### What's Changed - fix(1308): Handle nullable complex and nested value classes by [@​VasilisDrettas-tomtom](https://redirect.github.com/VasilisDrettas-tomtom) in [https://github.com/mockk/mockk/pull/1314](https://redirect.github.com/mockk/mockk/pull/1314) - Fix(Issue no. 1330) for Relaxed Mocking Value When Property is Nested Value Class by [@​kpadhiamex](https://redirect.github.com/kpadhiamex) in [https://github.com/mockk/mockk/pull/1331](https://redirect.github.com/mockk/mockk/pull/1331) ##### New Contributors - [@​kpadhiamex](https://redirect.github.com/kpadhiamex) made their first contribution in [https://github.com/mockk/mockk/pull/1331](https://redirect.github.com/mockk/mockk/pull/1331) **Full Changelog**: mockk/mockk@1.13.13...1.13.14 </details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The option in the ios menu to get to autofill settings is called "Passwords" instead of "Passwords & Accounts"
Existing instructions in App:
iOS Settings menu: