Skip to content

iOS Extension is not loading (#1624)#1631

Merged
jlf0dev merged 1 commit intomasterfrom
bug/ios-extension
Nov 5, 2021
Merged

iOS Extension is not loading (#1624)#1631
jlf0dev merged 1 commit intomasterfrom
bug/ios-extension

Conversation

@jlf0dev
Copy link
Member

@jlf0dev jlf0dev commented Nov 5, 2021

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

iOS extension is not loading.

This was an unintentional feature of our appearance tweaks in #1556. We used the ThemeManager to call colors for appearance adjustments before we had a ResourceDictionary loaded.

Asana Task: https://app.asana.com/0/1169444489336079/1201291162165972/f

Closes #1624

Code changes

  • src/iOS.Extension/LoadingViewController.cs: Load app resources before making appearance adjustments

Screenshots

Testing requirements

  • Test app extension can be turned on and loads correctly in different scenarios
  • Test extension appearance and theme is correct

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

@jlf0dev jlf0dev requested a review from mpbw2 November 5, 2021 13:42
Copy link
Contributor

@mpbw2 mpbw2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@jlf0dev jlf0dev merged commit df496e3 into master Nov 5, 2021
@jlf0dev jlf0dev deleted the bug/ios-extension branch November 5, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

iOS share sheet button not working

2 participants