Skip to content

[Key Connector] Hide MP input in iOS extensions#1656

Merged
eliykat merged 3 commits intomasterfrom
keyconnector/iOS-hide-mp
Nov 22, 2021
Merged

[Key Connector] Hide MP input in iOS extensions#1656
eliykat merged 3 commits intomasterfrom
keyconnector/iOS-hide-mp

Conversation

@eliykat
Copy link
Member

@eliykat eliykat commented Nov 22, 2021 •
edited
Loading

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Implements bitwarden/mobile#1654 for the iOS extension & autofill projects:

If a key connector user has biometrics set up on the lock screen, we want to hide the master password prompt. [...]

If the user is using a PIN with biometrics, the screen should remain the same and prompt for PIN input.

Code changes

  • src/iOS.Core/Controllers/LockPasswordViewController.cs:
    • hide the Submit button if using biometric unlock only (this is done by setting text to null and disabling it)
    • change the title text to "Unlock Vault" if using biometric unlock only
    • skip setup for the MasterPasswordCell if using biometric unlock only
    • if using biometric unlock only, move the "biometric cell" up to the first row, and adjust the length of the grid accordingly. To assist this, I've extracted the 'builder' logic for the biometric cell into a getter.

Please pay particular attention to the conditional logic involved - there are quite a few different combinations, and I'd like simpler logic, but I think this works.

Screenshots

Screen Shot 2021-11-22 at 2 04 39 pm

Testing requirements

  • confirm that the iOS unlock page conforms to the Figma and behaves as expected
  • full regression on iOS extension ("share") and autofill unlock page, especially with different combinations. e.g. MP only, MP + biometric, PIN only, PIN + biometric, biometric only.

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

@eliykat eliykat requested review from jlf0dev and mpbw2 November 22, 2021 04:05
jlf0dev
jlf0dev reviewed Nov 22, 2021
View reviewed changes
Copy link
Member

@jlf0dev jlf0dev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Approved but @mportune-bw might want to take a look as well

@eliykat eliykat merged commit ff35e3c into master Nov 22, 2021
@eliykat eliykat deleted the keyconnector/iOS-hide-mp branch November 22, 2021 23:50
fedemkr added a commit that referenced this pull request Nov 24, 2021
@fedemkr
Merge branch 'master' into account-deletion-final
515cfaf 
* master: (26 commits)
  Add support for Pluma Browser for Android (#1639)
  Update Focus/Klar accessibility and autofill IDs (#1535)
  Add workaround to Android entry renderer (#1658)
  [Key Connector] Hide MP input in iOS extensions (#1656)
  ui changes for lock screen if using key connector with biometrics (#1654)
  Revert "Add Share app Extension on iOS for Send (#1647)" (#1655)
  Add Share app Extension on iOS for Send (#1647)
  Bug/cme autofill unlock (#1653)
  ui changes export vault screen for key connector (#1651)
  Autosync the updated translations (#1652)
  Fixed missing FavIcons on Android #1640 (#1649)
  Hide Master Pass On Restart for Key Connector (#1650)
  Show SSO login if using key-connector without bio or pin (#1648)
  Autosync the updated translations (#1642)
  pass OrgId to SSO login while using CME (#1646)
  [KeyConnector] Add support for key connector OTP (#1633)
  [Linked fields] Add Linked Field as a custom field type (#1563)
  Change Release workflow to allow releases from 'rc' and 'hotfix' branches (#1632)
  fixing a typo (#1634)
  Updating the crowdin sync process (#1630)
  ...

# Conflicts:
#	src/App/Abstractions/IPasswordRepromptService.cs
#	src/App/Resources/AppResources.Designer.cs
#	src/App/Resources/AppResources.resx
#	src/App/Services/MobilePasswordRepromptService.cs
#	src/Core/Services/ApiService.cs
fedemkr added a commit that referenced this pull request Nov 24, 2021
@fedemkr
Merge branch 'master' into share_target_send_ios
7bed626 
* master:
  Added account deletion feature on settings (#1621)
  Add support for Pluma Browser for Android (#1639)
  Update Focus/Klar accessibility and autofill IDs (#1535)
  Add workaround to Android entry renderer (#1658)
  [Key Connector] Hide MP input in iOS extensions (#1656)
  ui changes for lock screen if using key connector with biometrics (#1654)
  Revert "Add Share app Extension on iOS for Send (#1647)" (#1655)
  Add Share app Extension on iOS for Send (#1647)
  Bug/cme autofill unlock (#1653)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jlf0dev jlf0dev jlf0dev approved these changes

@mpbw2 mpbw2 mpbw2 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eliykat @jlf0dev @mpbw2