Skip to content

Add logs to help solve iOS PN problem#1731

Merged
fedemkr merged 2 commits intomasterfrom
fix-ios-pn-tfproblem
Jan 25, 2022
Merged

Add logs to help solve iOS PN problem#1731
fedemkr merged 2 commits intomasterfrom
fix-ios-pn-tfproblem

Conversation

@fedemkr
Copy link
Member

@fedemkr fedemkr commented Jan 25, 2022

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Add logs and information to help figure out what's wrong on iOS push notifications. This PR should be reverted after we fix the iOS push notifications on TestFlight But we need this PR to trigger a new TestFlight version with additional logs

Code changes

  • Added logs and info on Settings about regarding PN registration

Testing requirements

This is merely for Dev logs.

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

* master:
  Expand Settings TimePicker tap recognition to entire row (#1714)
  Improve Theming (#1707)
@fedemkr fedemkr requested review from a team and vvolkgang January 25, 2022 18:34
@jlf0dev
Copy link
Member

jlf0dev commented Jan 25, 2022

Could we run a manual Build on your branch instead? Or is this a master specific issue?

@joseph-flinn is a manual Build on a certain branch possible? Just to send it to App Store Connect

@mpbw2
Copy link
Contributor

mpbw2 commented Jan 25, 2022

@jlf0dev Builds happen on all pushed branches (see the Actions tab to grab artifacts). Publishing to the test tracks (both google and testflight) isn't something we can cleanly one-off however, which is why it only happens in a go-forward manner (meaning this has to go to master for that to happen)

@fedemkr
Copy link
Member Author

fedemkr commented Jan 25, 2022

Also, we can't grab the ipa generated by the Actions build and install it directly on device because it's being built with AppStore configuration, so we need to go to master to generate the TestFlight build and so I can check what's going on with the iOS push notifications.

For the future maybe we could set up an AdHoc build that we can trigger to reproduce or test stuff in production-like mode without going to TestFlight, or add some kind of environment on AppCenter where we can trigger builds from specific branches to test this kind of stuff

@mpbw2
Copy link
Contributor

mpbw2 commented Jan 25, 2022

Just so everyone knows we can commit this to master safely. The automatic publishing only goes to internal users on both platforms, whereas public test tracks require action by a human. As long as it's reverted before we cut rc (which is when I typically start a public beta) we'll be good.

@jlf0dev
Copy link
Member

jlf0dev commented Jan 25, 2022

Ah gotcha, ok sounds good to me then. I was just worried since we have a short timeframe before we cut for rc. Maybe we can figure out an App Center or Ad Hoc build in the future :)

@fedemkr fedemkr merged commit 37f4439 into master Jan 25, 2022
@fedemkr fedemkr deleted the fix-ios-pn-tfproblem branch January 25, 2022 19:33
fedemkr added a commit that referenced this pull request Jan 28, 2022
* accountswitching:
  Update FA icons on LockPasswordViewController (#1729)
  Add Share app Extension on iOS for Send (re-PR) (#1660)
  Added hide loading after requesting OTP on verification code (#1732)
  Added Logs for PN registration checks (#1731)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants