Create and use Account Switching overlay control#1753
Merged
mpbw2 merged 3 commits intoaccountswitchingfrom Feb 7, 2022
Merged
Create and use Account Switching overlay control#1753mpbw2 merged 3 commits intoaccountswitchingfrom
mpbw2 merged 3 commits intoaccountswitchingfrom
Conversation
…actored accordingly
fedemkr
changed the title
8 tasks
mpbw2
reviewed
Feb 7, 2022
Contributor
mpbw2
left a comment
mpbw2
left a comment
There was a problem hiding this comment.
oops, meant to approve but merged instead. Guess the coffee wore off.
fedemkr
added a commit
that referenced
this pull request
Feb 7, 2022
…miss * accountswitching: Create and use Account Switching overlay control (#1753) # Conflicts: # src/App/Pages/Vault/GroupingsPage/GroupingsPage.xaml.cs
mpbw2
added a commit
that referenced
this pull request
Feb 23, 2022
* Account Switching (#1720) * Account switching * WIP * wip * wip * updates to send test logic * fixed Send tests * fixes for theme handling on account switching and re-adding existing account * switch fixes * fixes * fixes * cleanup * vault timeout fixes * account list status enhancements * logout fixes and token handling improvements * merge latest (#1727) * remove duplicate dependency * fix for initial login token storage paradox (#1730) * Fix avatar color update toolbar item issue on iOS for account switching (#1735) * Updated account switching menu UI (#1733) * updated account switching menu UI * additional changes * add key suffix to constant * GetFirstLetters method tweaks * Fix crash on account switching when logging out when having more than user at a time (#1740) * single account migration to multi-account on app update (#1741) * Account Switching Tap to dismiss (#1743) * Added tap to dismiss on the Account switching overlay and improved a bit the code * Fix account switching overlay background transparent on the proper place * Fixed transparent background and the shadow on the account switching overlay * Fix iOS top space on Account switching list overlay after modal (#1746) * Fix top space added to Account switching list overlay after closing modal * Fix top space added to Account switching list overlay after closing modal on lock, login and home views just in case we add modals in the future there as well * Usability: dismiss account list on certain events (#1748) * dismiss account list on certain events * use new FireAndForget method for back button logic * Create and use Account Switching overlay control (#1753) * Added Account switching overlay control and its own ViewModel and refactored accordingly * Fix account switching Accounts list binding update * Implemented dismiss account switching overlay when changing tabs and when selecting the same tab. Also updated the deprecated listener on CustomTabbedRenderer on Android (#1755) * Overriden Equals on AvatarImageSource so it doesn't get set multiple times when it's the same image thus producing blinking on tab chaged (#1756) * Usability improvements for logout on vault timeout (#1781) * accountswitching fixes (#1784) * Fix for invalid PIN lock state when switching accounts (#1792) * fix for pin lock flow * named tuple values and updated async * clear send service cache on account switch (#1796) * Global theme and account removal (#1793) * Global theme and account removal * remove redundant call to hide account list overlay * cleanup and additional tweaks * add try/catch to remove account dialog flow Co-authored-by: Federico Maccaroni <fedemkr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Add an account switching overlay control to be reused on all the views. Also add its own ViewModel to handle the logic and configuration.
Code changes
AccountSwitchingOverlayViewModelon each to offer the binding context for the new overlay control and configurationAccountViewsto be aListinstead of anExtendedObservableCollectiongiven that we don't change items while the view is open; it only changes when adding/removing accounts and that happens on pages transition so it doesn't make sense to use all the notifying events of theExtendedObservableCollection. And also the List is replaced completely when refreshing the accounts so a simpleListmakes more sense for this case given that there are just a few items.Testing requirements
Everything should work as before.
Before you submit