Skip to content

Add AppCenter secret to build workflow#1771

Merged
vgrassia merged 1 commit intoadd-dsym-buildfrom
update-build-workflow
Feb 11, 2022
Merged

Add AppCenter secret to build workflow#1771
vgrassia merged 1 commit intoadd-dsym-buildfrom
update-build-workflow

Conversation

@vgrassia
Copy link
Member

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

This PR adds the iOS AppCenter secret to the build workflow.

Code changes

  • .github/workflows/build.yml: Added login/key-vault steps to iOS job and used new secret in Upload dSYMs to App Center step.

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

@vgrassia vgrassia requested a review from fedemkr February 11, 2022 20:49
@vgrassia vgrassia self-assigned this Feb 11, 2022
@vgrassia vgrassia merged commit 977d505 into add-dsym-build Feb 11, 2022
@vgrassia vgrassia deleted the update-build-workflow branch February 11, 2022 20:55
fedemkr added a commit that referenced this pull request Feb 14, 2022
* Added dsym artifact to be uploaded alongside with the ipa o the build.yml

* Added dsym artifact to be uploaded alongside with the ipa o the build.yml

* Fixed build.yml dsym artifact

* Fix upload dsym build.yml

* Fix build.yml to check what gets exported and after this will become the adjustment for the dsym (disabling Android build for this test)

* Fix build.yml to copy all dsyms and artifact them (disabling Android build for this test)

* Fix build.yml to only copy all dsyms and ipa and artifact them (disabling Android build for this test)

* Added Appcenterr CLI and upload missing symbols for dSYM to the build

* Add secret to build workflow (#1771)

* Changed build.yml upload dsym command from upload-missing-symbols to upload-symbols

* Added restrictions for uploading iOS symbols to AppCenter on build.yml

Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants