Skip to content

Fix crash iOS AppDelegate OnActivated#1856

Merged
fedemkr merged 1 commit intomasterfrom
fix-ios-crash-onactivated
Mar 21, 2022
Merged

Fix crash iOS AppDelegate OnActivated#1856
fedemkr merged 1 commit intomasterfrom
fix-ios-crash-onactivated

Conversation

@fedemkr
Copy link
Member

@fedemkr fedemkr commented Mar 21, 2022

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fix crash happened on AppDelegate -> OnActivated

Code changes

  • AppDelegate: Added null check on OnActivated for the KeyWindow and also made a const for the tag of the splash view.

Testing requirements

The flow for the crash to happen is unknown but at least we should check that the splash shown when "minimizing" the app should be displayed correctly and hide correctly when going back to the application.

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

@fedemkr fedemkr requested a review from a team March 21, 2022 15:32
@fedemkr fedemkr enabled auto-merge (squash) March 21, 2022 15:34
@fedemkr fedemkr merged commit 840925c into master Mar 21, 2022
@fedemkr fedemkr deleted the fix-ios-crash-onactivated branch March 21, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants