EC-149 Fix crash when trying to Focus on Lock page#1879
Merged
Conversation
…improved the code so there are fewer direct access from the VM to the View
mpbw2
approved these changes
Jul 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Fix crash produced when focussing the pin/master password entry on the lock page after choosing the fallback method on a failed biometric scan.
I couldn't reproduced this but there are a lot of crashes reported on AppCenter so just fixed it where it's appearing to crash.
Also improved the code so that the ViewModel have fewer direct accesses to the View/Page.
Code changes
SecretEntrycentralizing the logic with thePinLockto get the correct entry. Also perform the logic of Focusing on thePageinvoking it on the main thread to avoid the crash.WeakEventManagerso we don't have to worry about memory leaks.Testing requirements
I couldn't reproduce the issue but given the crash report it would be like:
Also it could be like that but with the automatic prompting of biometrics when minimizing the app and starting it again.
Btw, if no biometrics is setup the pin/master password entry should be automatically focused (i.e. should work as before) and if biometrics are configured and the fallback is selected the same should happen, i.e. it should automatically focus the pin/master password.
Before you submit