Skip to content

SG-209 Account switching in autofill UI (Android)#1882

Merged
mpbw2 merged 1 commit intomasterfrom
feature-autofillaccountswitch
Apr 20, 2022
Merged

SG-209 Account switching in autofill UI (Android)#1882
mpbw2 merged 1 commit intomasterfrom
feature-autofillaccountswitch

Conversation

@mpbw2
Copy link
Contributor

@mpbw2 mpbw2 commented Apr 15, 2022

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Added support for account switching within the autofill UI on Android

Code changes

  • AutofillCiphersPage.xaml: Added AvatarImageSource to toolbar, additional ShowNoData property (explained below), and AccountSwitchingOverlayView control to layout
  • AutofillCiphersPage.xaml.cs/AutofillCiphersPageViewModel.cs: Added avatar & overlay support, plus separate loading & "NoData" states to smooth out UX when switching accounts (previously "NoData" was simply the negated "HasData" resulting in "No Matches" being shown momentarily before showing the matches)
  • App.xaml.cs: Added additional condition for clearing Options.Uri upon exiting the autofill flow (required to prevent main app from falling back into "autofill matches" view when switching accounts, as that triggers the SetMainPageAsync() flow that shows autofill matches if Options.Uri has value)

Testing requirements

Testing should consist of three parts:

  1. Obvious: Trigger autofill, switch users, unlock if necessary, select matches
  2. Less Obvious: Make sure main app continues to behave normally after using autofill flow (including saving new creds during autofill)
  3. Not Remotely Obvious: File selection flow (via file attachments and file Sends)

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

@mpbw2 mpbw2 requested review from a team and vvolkgang April 15, 2022 21:13
Copy link
Member

@vvolkgang vvolkgang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mpbw2 mpbw2 merged commit cfbbea5 into master Apr 20, 2022
@mpbw2 mpbw2 deleted the feature-autofillaccountswitch branch April 20, 2022 00:38
@mpbw2 mpbw2 changed the title Account switching in autofill UI (Android) SG-209 Account switching in autofill UI (Android) Apr 26, 2022
@fedemkr fedemkr linked an issue May 17, 2022 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Account Switching Not Possible When Current Vault is Unlocked

2 participants