Skip to content

[EC-326] Add support for iodé Browser#1886

Merged
vvolkgang merged 1 commit intobitwarden:masterfrom
vincentvidal:iode-support
Jul 14, 2022
Merged

[EC-326] Add support for iodé Browser#1886
vvolkgang merged 1 commit intobitwarden:masterfrom
vincentvidal:iode-support

Conversation

@vincentvidal
Copy link

This adds support for iodé Browser (https://gitlab.com/iode/os/apps/iodebrowser), a Firefox fork developed for the iodéOS privacy-oriented rom (but can be used independently of the rom).

@CLAassistant
Copy link

CLAassistant commented Apr 22, 2022

CLA assistant check
All committers have signed the CLA.

@contribucious
Copy link

Hello @vincentvidal,
 

Thank you for your contribution. 🙂
 

Please see, however, this remark (point n°2 only in your case) as it applies to your contribution as well. 😉

@vincentvidal
Copy link
Author

Hi,

Thanks for the review. I've updated the commit.

@contribucious
Copy link

Great. Don't forget to sort it also in src/Android/Resources/xml/autofillservice.xml however. 👍

@vincentvidal
Copy link
Author

Hum. Thanks a lot for your patience...

@contribucious
Copy link

No problem. 😉

Looks good to me! (cc @mp-bw)

P.S. for the Bitwarden team > Regarding the maxLongVersionCode value (related to this), I think it's best to make a dedicated PR one day to properly update the various Firefox forks all at once.

@djsmith85 djsmith85 linked an issue May 2, 2022 that may be closed by this pull request
1 task
@djsmith85 djsmith85 changed the title Add support for iodé Browser [PS-651] Add support for iodé Browser May 17, 2022
@vvolkgang vvolkgang changed the title [PS-651] Add support for iodé Browser [C-326] Add support for iodé Browser Jul 14, 2022
@vvolkgang vvolkgang changed the title [C-326] Add support for iodé Browser [EC-326] Add support for iodé Browser Jul 14, 2022
@vvolkgang vvolkgang merged commit f2ba86a into bitwarden:master Jul 14, 2022
@dwbit
Copy link
Collaborator

dwbit commented Aug 24, 2022

Hey @vincentvidal, thanks again for your contribution! The team would like to send you a thank you, please provide your contact info here if interested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Autofill on iode browser

6 participants