Conversation
# Conflicts: # src/App/App.xaml.cs
mpbw2
approved these changes
Jul 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Improve
BroadcastServiceon exception handling and also addtry...catchon async void callbacks of theBroadcastService.Code changes
Send(Message message, string id)because currently theidis not being sent by any method so we're doing some checks inside that never apply. Thus it made sense to split it so that we avoid this little overhead (and also the other method will be stripped out by the linker unless we call it from somewhere). In addition, exception handling was added to the call of the message action because it was being swallowed by the task thus we were not getting any reports to AppCenter if something failed.###Notes:
BroadcastServiceand theIMessagingServiceneeds further refactoring to improve the code and the dev experience but I'll do it on a different PR.Before you submit