[SG-390] Fix for missing org items with single org & personal ownership enabled#1953
Merged
[SG-390] Fix for missing org items with single org & personal ownership enabled#1953
Conversation
mpbw2
changed the title
fedemkr
requested changes
Jun 15, 2022
| _hideMyVaultFilterOption = await policyService.PolicyAppliesToUser(PolicyType.PersonalOwnership); | ||
| if (_vaultFilterSelection == null) | ||
| _personalOwnershipPolicyApplies = await policyService.PolicyAppliesToUser(PolicyType.PersonalOwnership); | ||
| _singleOrgPolicyApplies = await policyService.PolicyAppliesToUser(PolicyType.OnlyOrg); |
Member
There was a problem hiding this comment.
_singleOrgPolicyApplies doesn't need to be a field, it can be a var or directly put the await call inside the if
fedemkr
approved these changes
Jun 15, 2022
mpbw2
added a commit
that referenced
this pull request
Jun 15, 2022
…ip enabled (#1953) * fix for missing org items with single org & personal ownership enabled * fix for ui issue with vault filter state change on pull to refresh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
This fixes an issue where org items were not appearing when the vault filter control was hidden due to the single org and personal ownership policies both being enabled.
Code changes
ShowVaultFilterto properly draw the org name in the vault filter if the filter was previously hidden but now shown after a refresh.Before you submit
dotnet tool run dotnet-format --check) (required)