Skip to content

[SG-396] Fix tappable area after hiding account switching on Autofill#1956

Merged
fedemkr merged 1 commit intomasterfrom
bug/SG-396-fix-select-vault-items-after-ac-switching-hide
Jun 16, 2022
Merged

[SG-396] Fix tappable area after hiding account switching on Autofill#1956
fedemkr merged 1 commit intomasterfrom
bug/SG-396-fix-select-vault-items-after-ac-switching-hide

Conversation

@fedemkr
Copy link
Member

@fedemkr fedemkr commented Jun 16, 2022

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

On Autofill, after hiding the account switching overlay the user can't select any items. So this fixes the tap area.

Code changes

  • AccountSwitchingOverlayView.xaml.cs: Added AfterHide action to invoke after hiding the account switching overlay
  • AccountSwitchingOverlayHelper.cs: Hide the container of the account switching overlay after the overlay hidden animation finishes. Fix one tiny animation issue when displaying the overlay

Before you submit

  • I have checked for formatting errors (dotnet tool run dotnet-format --check) (required)
  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

@fedemkr fedemkr requested review from a team and mpbw2 June 16, 2022 19:02
@fedemkr fedemkr added the ios label Jun 16, 2022
@fedemkr fedemkr enabled auto-merge (squash) June 16, 2022 19:37
@fedemkr fedemkr merged commit b250055 into master Jun 16, 2022
@fedemkr fedemkr deleted the bug/SG-396-fix-select-vault-items-after-ac-switching-hide branch June 16, 2022 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants