[PS 920] Fix selfhosted url validations#1967
Merged
LRNcardozoWDF merged 10 commits intomasterfrom Jul 11, 2022
Merged
Conversation
* Added feedback to user when trying to perform login with bad formed URL
*(missing file from previous commit)
Closed
1 task
fedemkr
requested changes
Jun 29, 2022
Member
fedemkr
left a comment
There was a problem hiding this comment.
A couple of things to improve and on the PR:
- Change the title to
[PS-920] Fix environment url validationsso the format is alike the other PRs. - On the description, I'd clarify that
Settingspage is the environment's one or it could be misleading to the Settings tab in the app's home.
* Added comment for hard coded string
* Fixed url validations * Refactored method to local function
fedemkr
requested changes
Jul 5, 2022
Member
fedemkr
left a comment
There was a problem hiding this comment.
Good work, just one thing I forgot to mention on the first review, and even though the method didn't have exception handling before, we should add it.
* Added generic error message string to AppResources
fedemkr
previously approved these changes
Jul 8, 2022
# Conflicts: # src/App/Resources/AppResources.Designer.cs # src/App/Resources/AppResources.resx
fedemkr
approved these changes
Jul 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Added feedback to user when saving a bad formed URL in Settings page or trying to perform login with a previously saved bad formed url.
Code changes
Screenshots
Before you submit
dotnet tool run dotnet-format --check) (required)