[EC-259] Added Account Switching to Share extension on iOS#1971
Merged
[EC-259] Added Account Switching to Share extension on iOS#1971
Conversation
…ed performance for this and exception handling
jlf0dev
reviewed
Jul 12, 2022
Member
jlf0dev
left a comment
There was a problem hiding this comment.
I haven't been in mobile land in a little bit, but went ahead and took a look through this just in case no one else has time. I have a couple questions but overall it looks good.
…p date and time at the same time and applied on usage
jlf0dev
approved these changes
Jul 12, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Added Account Switching to Share extension on iOS and focused on improving memory usage so that the extension doesn't crash.
Code changes
AvatarImageSourcePoolAvatarImageSourcePoolAvatarImageSourceacross the appDateTimePickerOnCloseAction given that now a different page is used by the extensionDeletionDateTimeViewModelandExpirationDateTimeViewModelto handle date and time and use theDateTimePickerlazily.SendAddOnlyPageso avoid memory spiking when loading the page. It's basically theOptionspart that can be shown/hidden by the button in theSendAddOnlyPage, given that's lazy, it's only going to be loaded the first time the user wants to show the options.SendAddEditPagebut it only has add mode and controls that are used only on adding and specifically for the iOS share extension. With this we remove code and the memory usage decreases. Also, it just loads the view directly instead of usingLoadOnAppearedAsyncgiven that the load time is almost nothing, therefore the loading indicator is not seen and this doesn't make sense, therefore we save some memory and cpu time here as well.UINavigationBarand not only to the currentNavigationControllerAvatarImageSourcePooland addedInitApp<T>(...)method to be reused on the iOS extensions.ExtensionNavigationControllerfor proper disposal of controllers, improved get provider type and improved navigations to dispose resources appropriately.Screenshots
Before you submit
dotnet tool run dotnet-format --check) (required)