Skip to content

[EC-297] Fix possible crash when copying password on cipher item view#1974

Merged
fedemkr merged 1 commit intomasterfrom
EC-297-try-catch-on-copy-password
Jul 5, 2022
Merged

[EC-297] Fix possible crash when copying password on cipher item view#1974
fedemkr merged 1 commit intomasterfrom
EC-297-try-catch-on-copy-password

Conversation

@fedemkr
Copy link
Member

@fedemkr fedemkr commented Jul 4, 2022

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fix possible crash when copying password on cipher item view

Code changes

  • ClipboardService.cs: Added try catch ignore for the specific exception on the issue reported
  • ViewPageViewModel.cs: Improved the copying commands

Before you submit

  • I have checked for formatting errors (dotnet tool run dotnet-format --check) (required)
  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

…Also improved a bit the code of copying commands
@fedemkr fedemkr requested a review from a team July 4, 2022 18:12
@fedemkr fedemkr linked an issue Jul 4, 2022 that may be closed by this pull request
1 task
@fedemkr fedemkr merged commit d246d1d into master Jul 5, 2022
@fedemkr fedemkr deleted the EC-297-try-catch-on-copy-password branch July 5, 2022 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash when copy password to clipboard on my phone

2 participants