Skip to content

[EC-308] Fix crash on avatar image creation on iOS Autofill#1983

Merged
fedemkr merged 2 commits intomasterfrom
bug/EC-308-null-ref-acc-sw-avatar-creation
Jul 7, 2022
Merged

[EC-308] Fix crash on avatar image creation on iOS Autofill#1983
fedemkr merged 2 commits intomasterfrom
bug/EC-308-null-ref-acc-sw-avatar-creation

Conversation

@fedemkr
Copy link
Member

@fedemkr fedemkr commented Jul 7, 2022

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fixes crash produced when creating the avatar image on iOS Autofill

Code changes

  • AccountSwitchingOverlayHelper.cs: Added exception handling, default image to return and some logging
  • ImageSourceExtensions.cs: Added proper logging

Screenshots

When an error occurs on creating the avatar image then the default one will be displayed

Default avatar image

Before you submit

  • I have checked for formatting errors (dotnet tool run dotnet-format --check) (required)
  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

@fedemkr fedemkr requested a review from a team July 7, 2022 17:31
@fedemkr fedemkr enabled auto-merge (squash) July 7, 2022 17:33
Copy link
Member

@vvolkgang vvolkgang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one suggestion

@fedemkr fedemkr merged commit 846d3a8 into master Jul 7, 2022
@fedemkr fedemkr deleted the bug/EC-308-null-ref-acc-sw-avatar-creation branch July 7, 2022 19:24
@fedemkr fedemkr linked an issue Jul 18, 2022 that may be closed by this pull request
1 task
trmartin4 pushed a commit that referenced this pull request Jul 20, 2022
…gOverlayHelper and also added more logging to see when it happens. (#1983)

(cherry picked from commit 846d3a8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto-fill not launching [iOS]

2 participants