Skip to content

[PS-1074] Use correct icon for checked/unchecked boolean#1986

Merged
fedemkr merged 1 commit intobitwarden:masterfrom
patrickhlauke:patch-1
Jul 11, 2022
Merged

[PS-1074] Use correct icon for checked/unchecked boolean#1986
fedemkr merged 1 commit intobitwarden:masterfrom
patrickhlauke:patch-1

Conversation

@patrickhlauke
Copy link

@patrickhlauke patrickhlauke commented Jul 9, 2022

Closes bitwarden/mobile#1985

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fixes the problem of boolean custom fields showing the opposite of their value at the moment

Code changes

  • src/App/Pages/Vault/ViewPageViewModel.cs: Swap around the icons used

Before you submit

  • I have checked for formatting errors (dotnet tool run dotnet-format --check) (required)
  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PS-1074

@bitwarden-bot bitwarden-bot changed the title Use correct icon for checked/unchecked boolean [PS-1069] Use correct icon for checked/unchecked boolean Jul 9, 2022
@vvolkgang vvolkgang added bug and removed community-pr labels Jul 9, 2022
@vvolkgang vvolkgang changed the title [PS-1069] Use correct icon for checked/unchecked boolean [PS-1074] Use correct icon for checked/unchecked boolean Jul 9, 2022
Copy link
Member

@fedemkr fedemkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution, approving this

@fedemkr fedemkr merged commit 75e8276 into bitwarden:master Jul 11, 2022
@patrickhlauke patrickhlauke deleted the patch-1 branch July 11, 2022 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Boolean custom field displays ticked checkbox when unchecked, unticked checkbox when checked

4 participants