Skip to content

[EC-323] Fix error when getting the first letters on avatar image creation#1990

Merged
vvolkgang merged 1 commit intomasterfrom
bug/EC-323-fix-get-first-letters-on-avatar-creation
Jul 14, 2022
Merged

[EC-323] Fix error when getting the first letters on avatar image creation#1990
vvolkgang merged 1 commit intomasterfrom
bug/EC-323-fix-get-first-letters-on-avatar-creation

Conversation

@fedemkr
Copy link
Member

@fedemkr fedemkr commented Jul 13, 2022

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fix getting the first letters on avatar image creation. There are some cases when more spaces are added, at the beginning, at the end or in the middle that causes the method to fail.

Code changes

  • AvatarImageSource.cs: Sanitized data on getting first letters so that it doesn't fail when more spaces are added

Before you submit

  • I have checked for formatting errors (dotnet tool run dotnet-format --check) (required)
  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

@fedemkr fedemkr requested a review from a team July 13, 2022 21:13
Copy link
Member

@vvolkgang vvolkgang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might have to revisit this but let's merge the fix for now!

@vvolkgang vvolkgang merged commit 8f3a4b9 into master Jul 14, 2022
@vvolkgang vvolkgang deleted the bug/EC-323-fix-get-first-letters-on-avatar-creation branch July 14, 2022 20:33
@fedemkr fedemkr linked an issue Jul 18, 2022 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto-fill not launching [iOS]

2 participants