[PS-1227] About information not available when logged out#2020
Closed
deividt wants to merge 1 commit intobitwarden:mainfrom
deividt:dg/feature/about-information-not-available-when-logged-out
Closed
[PS-1227] About information not available when logged out#2020deividt wants to merge 1 commit intobitwarden:mainfrom deividt:dg/feature/about-information-not-available-when-logged-out
deividt wants to merge 1 commit intobitwarden:mainfrom
deividt:dg/feature/about-information-not-available-when-logged-out
Conversation
|
Thank you for your contribution! We've added this to our internal Community PR board for review. |
1 task
1 task
|
Is the About issue resolved, doesn't seem like it is resolved, can I work on it? |
|
Hey, I wanna work on this as well! 🥉 |
|
Hello @deividt , thanks for your contribution. Unfortunately there are some upcoming changes for our mobile app which is quite significant, and unfortunately this contribution doesn’t align with that direction. Would have to close this out. Thank you again for the help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
This PR fixes the #2010 issue. It adds the "About" and "Help and Feedback" buttons to the settings pages when the user is logged out. Allowing to check the app version as well as copying it to the clipboard. In addition to that the user has an easy access to the Bitwarden help page.
Important:
The "Help and Feedback" button is not necessary to fix the issue, but I thought it would be important to add it since I didn't find it when the user is logged out too. What do you think?
Code changes
Screenshots
Before you submit
dotnet tool run dotnet-format --check) (required)