Skip to content

[PS-1227] About information not available when logged out#2020

Closed
deividt wants to merge 1 commit intobitwarden:mainfrom
deividt:dg/feature/about-information-not-available-when-logged-out
Closed

[PS-1227] About information not available when logged out#2020
deividt wants to merge 1 commit intobitwarden:mainfrom
deividt:dg/feature/about-information-not-available-when-logged-out

Conversation

@deividt
Copy link
Copy Markdown

@deividt deividt commented Aug 1, 2022

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

This PR fixes the #2010 issue. It adds the "About" and "Help and Feedback" buttons to the settings pages when the user is logged out. Allowing to check the app version as well as copying it to the clipboard. In addition to that the user has an easy access to the Bitwarden help page.

Important:
The "Help and Feedback" button is not necessary to fix the issue, but I thought it would be important to add it since I didn't find it when the user is logged out too. What do you think?

Code changes

  • EnvironmentPage.xaml: Added the "About" and "Help and feedback" buttons in a new block called "Other" at the end of the EnvironmentPage. I followed the same style of the SettingsPage.
  • EnvironmentPageViewModel.cs: Added the commands that will trigger the actions of the buttons added in the EnvironmentPage.
  • SettingsPageViewModel.cs: Removed the code that triggers the button "About". Its code was moved to the AppHelpers class.
  • AppHelpers.cs: Added the "ShowAppVersionAsync" function, which will be used to show the app version at any place of the app. Such as: SettingsPage and EnvironmentPage.

Screenshots

Screenshot_1659319906

Before you submit

  • I have checked for formatting errors (dotnet tool run dotnet-format --check) (required)
  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

@deividt deividt marked this pull request as ready for review August 1, 2022 02:59
@bitwarden-bot
Copy link
Copy Markdown

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PS-1227

@bitwarden-bot bitwarden-bot changed the title About information not available when logged out [PS-1227] About information not available when logged out Aug 1, 2022
@djsmith85 djsmith85 linked an issue Sep 9, 2022 that may be closed by this pull request
1 task
@toruwatanbe
Copy link
Copy Markdown

Is the About issue resolved, doesn't seem like it is resolved, can I work on it?

@tactipus
Copy link
Copy Markdown

Hey, I wanna work on this as well! 🥉

@dbosompem
Copy link
Copy Markdown

Hello @deividt , thanks for your contribution. Unfortunately there are some upcoming changes for our mobile app which is quite significant, and unfortunately this contribution doesn’t align with that direction. Would have to close this out. Thank you again for the help!

@dbosompem dbosompem closed this Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

About information not available when logged out

5 participants