Conversation
… on passphrase separator
fedemkr
requested changes
Aug 15, 2022
Member
|
Forgot to add it to the PR review comments but please update the PR objective |
…fect Improved code
fedemkr
requested changes
Aug 16, 2022
fedemkr
approved these changes
Aug 16, 2022
…-generator-keyboard
aj-rosado
deleted the
bug/PS-1009-removed-emojis-from-passphrase-generator-keyboard
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Remove the possibility of adding emojis on the word separator at Generator when passphrase is selected
Code changes
Screenshots
Before you submit
dotnet tool run dotnet-format --check) (required)