[PS-1353] Add support for the Neeva app#2045
Merged
djsmith85 merged 3 commits intobitwarden:masterfrom Dec 28, 2022
Merged
Conversation
|
Thank you for your contribution! We've added this to our internal Community PR board for review. |
bitwarden-bot
changed the title
ArthurFriedenreich
approved these changes
Nov 10, 2022
|
It's about time to get Neeva browser registered in Bitwarden. |
djsmith85
approved these changes
Dec 28, 2022
Contributor
djsmith85
left a comment
djsmith85
left a comment
There was a problem hiding this comment.
@dan-alcantara-neeva Thank you for your contribution. The changes are looking good and will be included in the next mobile release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Add support for the Neeva app.
https://community.bitwarden.com/t/adding-support-on-android-for-the-neeva-browser/43757
Code changes
Copied and tweaked https://github.com/bitwarden/mobile/pull/1855/files:
AccessibilityHelpers.cswas adjusted to be able to find the View ID of a TextView that contains the full URL of the page.AutofillHelpers.csandautofillservice.xmlwere edited to allow working with the Neeva app's package.Before you submit
dotnet tool run dotnet-format --check) (required)