Improve the toast notifcations on Windows#205
Closed
alistair23 wants to merge 2 commits intobitwarden:masterfrom
Closed
Improve the toast notifcations on Windows#205alistair23 wants to merge 2 commits intobitwarden:masterfrom
alistair23 wants to merge 2 commits intobitwarden:masterfrom
Conversation
kspearrin
reviewed
Dec 13, 2017
src/UWP/UWP.csproj
Outdated
Member
There was a problem hiding this comment.
We can't only update UWP here. We should update all projects. I'll look into that and report back
Author
There was a problem hiding this comment.
Ok, I don't actually need the update for UWP to work, so I'll update this PR dropping this patch.
On Windows we want to set the toast notifcation colours. Let's add a helper function to set the colour. Signed-off-by: Alistair Francis <alistair@alistair23.me>
Signed-off-by: Alistair Francis <alistair@alistair23.me>
alistair23
force-pushed
the
alistair/toast
branch
from
9fad2eb to
514f8ff
Compare
Member
|
We should probably shift this to the IDeviceAction service on each platform. I'd like to eventually get rid of UserDialogs all together so this is probably a good first step. |
Author
|
Ok. I'm not completely sure what you are looking for with that, so I might leave that up to you. I also have no way to test the other devices. Maybe I can revisit this in the future |
Closed
vvolkgang
pushed a commit
that referenced
this pull request
Jun 20, 2024
UCan927
pushed a commit
to UCan927/BitWarden-Android
that referenced
this pull request
Jun 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.