Added accessibility service disclosure prompt for Android#2102
Merged
Conversation
fedemkr
requested changes
Sep 27, 2022
| HorizontalOptions="End" /> | ||
| <Button | ||
| Clicked="ToggleAccessibility" | ||
| Clicked="ToggleAccessibilityAsync" |
Comment on lines
58
to
64
| private async void ToggleAccessibilityAsync(object sender, EventArgs e) | ||
| { | ||
| if (DoOnce()) | ||
| { | ||
| _vm.ToggleAccessibility(); | ||
| await _vm.ToggleAccessibilityAsync(); | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
This can be removed if we take the command approach. Furthermore, if we keep it like this it will crash the app if an exception is thrown.
Comment on lines
+188
to
+192
| if (accept) | ||
| { | ||
| _deviceActionService.OpenAccessibilitySettings(); | ||
| } | ||
| return; |
Member
There was a problem hiding this comment.
You can simplify it by:
if (!accept)
{
return;
}and if it's accepted it will just use the call outside the if to open the a11y settings
src/App/Resources/AppResources.resx
Outdated
Comment on lines
+2452
to
+2463
| <data name="AccessibilityDisclosureTitle" xml:space="preserve"> | ||
| <value>Accessibility Service Disclosure</value> | ||
| </data> | ||
| <data name="AccessibilityDisclosureText" xml:space="preserve"> | ||
| <value>Bitwarden uses the Accessibility Service to search for login fields in apps and websites, then establish the appropriate field IDs for entering a username & password when a match for the app or site is found. We do not store any of the information presented to us by the service, nor do we make any attempt to control any on-screen elements beyond text entry of credentials.</value> | ||
| </data> | ||
| <data name="AcceptAccessibilityDisclosure" xml:space="preserve"> | ||
| <value>Accept</value> | ||
| </data> | ||
| <data name="DeclineAccessibilityDisclosure" xml:space="preserve"> | ||
| <value>Decline</value> | ||
| </data> |
Member
There was a problem hiding this comment.
Except for AccessibilityDisclosureText I think the other ones should have the key alike to the value:
<data name="AccessibilityServiceDisclosure" xml:space="preserve">
<value>Accessibility Service Disclosure</value>
</data>
<data name="Accept" xml:space="preserve">
<value>Accept</value>
</data>
<data name="Decline" xml:space="preserve">
<value>Decline</value>
</data>
fedemkr
approved these changes
Sep 27, 2022
mpbw2
added a commit
that referenced
this pull request
Sep 28, 2022
Ldoppea
referenced
this pull request
in cozy/cozy-pass-mobile
Jun 5, 2023
Now that we're targeting API 32 we're required to comply with Google new policy regarding non-accessibility apps using accessibility services. This PR adds the disclosure and consent prompt as described on the help page. https://support.google.com/googleplay/android-developer/answer/10964491 This PR is a partial cherry pick from Bitwarden's changes Related PR: bitwarden/mobile#2102 Related PR: bitwarden/mobile#2104
Ldoppea
referenced
this pull request
in cozy/cozy-pass-mobile
Jun 5, 2023
Now that we're targeting API 32 we're required to comply with Google new policy regarding non-accessibility apps using accessibility services. This PR adds the disclosure and consent prompt as described on the help page. https://support.google.com/googleplay/android-developer/answer/10964491 This PR is a partial cherry pick from Bitwarden's changes Related PR: bitwarden/mobile#2102 Related PR: bitwarden/mobile#2104
Ldoppea
referenced
this pull request
in cozy/cozy-pass-mobile
Jun 27, 2023
Now that we're targeting API 32 we're required to comply with Google new policy regarding non-accessibility apps using accessibility services. This PR adds the disclosure and consent prompt as described on the help page. https://support.google.com/googleplay/android-developer/answer/10964491 This PR is a partial cherry pick from Bitwarden's changes Related PR: bitwarden/mobile#2102 Related PR: bitwarden/mobile#2104
Ldoppea
referenced
this pull request
in cozy/cozy-pass-mobile
Jun 27, 2023
Now that we're targeting API 32 we're required to comply with Google new policy regarding non-accessibility apps using accessibility services. This PR adds the disclosure and consent prompt as described on the help page. https://support.google.com/googleplay/android-developer/answer/10964491 This PR is a partial cherry pick from Bitwarden's changes Related PR: bitwarden/mobile#2102 Related PR: bitwarden/mobile#2104
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Now that we're targeting API 32 we're required to comply with this policy regarding non-accessibility apps using accessibility services. This PR adds the disclosure and consent prompt as described on the help page.
Code changes
isAccessibilityTool="false"per documentation (already defaults tofalsebut added for completeness)Screenshots
Before you submit
dotnet format --verify-no-changes) (required)