[SG-690] Login Request does not disappear after 15 minutes#2106
Merged
andrebispo5 merged 5 commits intomasterfrom Sep 30, 2022
Merged
[SG-690] Login Request does not disappear after 15 minutes#2106andrebispo5 merged 5 commits intomasterfrom
andrebispo5 merged 5 commits intomasterfrom
Conversation
…o not prompt login requests if 15mins have passed. Add constant for timeout time.
# Conflicts: # src/Android/Services/AndroidPushNotificationService.cs
fedemkr
requested changes
Sep 30, 2022
fedemkr
approved these changes
Sep 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Login requests were supposed to be removed from the mobile device after 15 minutes had passed and they were expired. Currently, whether the login request is already open in the app, or you have not yet opened the app to view the request, the request does not disappear. This also leads to an issue where, if you approve/deny the login request, you receive a confusing error message stating that something went wrong.
Code changes
On Android:
Screenshots
Before you submit
dotnet format --verify-no-changes) (required)