Skip to content

[SG-690] Login Request does not disappear after 15 minutes#2106

Merged
andrebispo5 merged 5 commits intomasterfrom
bugfix/SG-690-notif_dismiss
Sep 30, 2022
Merged

[SG-690] Login Request does not disappear after 15 minutes#2106
andrebispo5 merged 5 commits intomasterfrom
bugfix/SG-690-notif_dismiss

Conversation

@andrebispo5
Copy link
Contributor

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Login requests were supposed to be removed from the mobile device after 15 minutes had passed and they were expired. Currently, whether the login request is already open in the app, or you have not yet opened the app to view the request, the request does not disappear. This also leads to an issue where, if you approve/deny the login request, you receive a confusing error message stating that something went wrong.

Code changes

  • Before showing a modal, the app checks if the request is expired and silently ignores it.
  • When already showing the modal, if the user clicks Confirm/Deny the app checks if the request is expired and shows a dialog. When the dialog is closed, the modal is also closed and the request is ignored.

On Android:

  • After 15mins the system notification is automatically dismissed.

Screenshots

image

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

…o not prompt login requests if 15mins have passed. Add constant for timeout time.
# Conflicts:
#	src/Android/Services/AndroidPushNotificationService.cs
@andrebispo5 andrebispo5 requested a review from a team September 30, 2022 14:23
@andrebispo5 andrebispo5 requested a review from fedemkr September 30, 2022 15:56
@andrebispo5 andrebispo5 merged commit 90e0b5d into master Sep 30, 2022
@andrebispo5 andrebispo5 deleted the bugfix/SG-690-notif_dismiss branch September 30, 2022 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants